lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] net: phy: leds: Add support for "link" trigger
From
Date
Hi Andrew,

On 01.11.2017 13:31, Andrew Lunn wrote:
>> Yes, I did it the same way as the existing code did for phy->phy_led_triggers
>> for reasons of both consistency and also to be on the safe side because
>> maybe there is some non-obvious reason why it has to be freed
>> explicitly (?).
>
> Hi Maciej
>
> Occasionally, there is a need to call devm_kfree(). But i don't see
> anything here why it is needed. So i would drop your devm_kfree(), and
> if you feel like it, add an additional patch removing the existing
> one.

OK, will do as you suggest.

> Thanks
> Andrew
>

Thanks,
Maciej

\
 
 \ /
  Last update: 2017-11-01 13:34    [W:0.064 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site