lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend
From
Date
Okay, I will send a patch :)


Thanks,
Jia-Ju Bai

On 2017/10/9 13:43, Greg KH wrote:
> On Mon, Oct 09, 2017 at 09:10:28AM +0800, Jia-Ju Bai wrote:
>> According to device_main.c, the driver may sleep under a spinlock,
>> and the function call path is:
>> vt6655_suspend (acquire the spinlock)
>> pci_set_power_state
>> __pci_start_power_transition (drivers/pci/pci.c)
>> msleep --> may sleep
>>
>> A possible fix is to replace msleep with mdelay in
>> __pci_start_power_transition in drivers/pci/pci.c.
> Patches are usually best to send in for things that you find like this.
>
> thanks,
>
> greg k-h


\
 
 \ /
  Last update: 2017-10-09 09:58    [W:0.042 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site