lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks
Date
On Mon, 2017-10-09 at 16:22 +0300, Michael S. Tsirkin wrote:
> On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote:
> > The purpose of patch "linux/types.h: enable endian checks for all
> > sparse builds" was to encourage driver authors to annotate
> > endianness correctly in their drivers. However, since that patch
> > went upstream no endianness annotations in drivers have been fixed.
> > I think that this shows that the followed approach does not work,
> > probably because several driver authors do not use sparse. Restore
> > the ability to disable sparse endianness checks such that it
> > becomes again easy to review other sparse diagnostics for people
> > who want to analyze drivers they are not the author of.
> >
> > References: commit 05de97003c77 ("linux/types.h: enable endian checks for all sparse builds")
> > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
>
> I still think the new default is good. You probably want ability to
> disable these checks selectively for the specific drivers though. Makes
> it easier to spot what needs to be fixed.

Hello MST,

I agree with what you wrote. And what you described is what my patch implements
- keep endianness checking enabled by default and make it possible to disable it
selectively. Does that mean that you agree with the patch I posted?

Thanks,

Bart.
\
 
 \ /
  Last update: 2017-10-09 17:08    [W:0.100 / U:19.372 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site