lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 165/192] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes
    3.16.49-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Bogdan Nechita <dan.bogdan.nechita@gmail.com>

    commit 1bb850a1b7f68b66361e658e334f9fdf8231f17d upstream.

    Currently writing the attributes with "echo" will result in comparing:
    "enabled\n" with "enabled\0" and attribute is always set to false.

    Use the sysfs_streq() instead because it treats both NUL and
    new-line-then-NUL as equivalent string terminations.

    Signed-off-by: Dan Bogdan Nechita <dan.bogdan.nechita@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/misc/ad525x_dpot.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/misc/ad525x_dpot.c
    +++ b/drivers/misc/ad525x_dpot.c
    @@ -457,7 +457,7 @@ static ssize_t sysfs_set_reg(struct devi
    int err;

    if (reg & DPOT_ADDR_OTP_EN) {
    - if (!strncmp(buf, "enabled", sizeof("enabled")))
    + if (sysfs_streq(buf, "enabled"))
    set_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);
    else
    clear_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);
    \
     
     \ /
      Last update: 2017-10-09 16:01    [W:4.277 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site