Messages in this thread | | | From | Rob Herring <> | Date | Mon, 9 Oct 2017 08:05:44 -0500 | Subject | Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output interface |
| |
On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang <hjc@rock-chips.com> wrote: > Hi rob, > Thanks for your reply. > > 在 2017/10/4 5:56, Rob Herring 写道: >> >> On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote: >>> >>> This path add support rv1108 rgb output interface driver. >>> >>> Signed-off-by: Sandy Huang <hjc@rock-chips.com> >>> --- >>> Changes in v2: >>> 1. rename rockchip,rgb-mode to rgb-mode; >> >> >> You can't just drop the vendor. This needs to be documented in a common >> place that others will find and use. See panel-common.txt or >> panel-dpi.txt. >> >> Alternatively, you could just drop it and let the panel compatible imply >> what the mode is. >> >> > ok, get it, i will move the rgb-mode to panel and describe it at > panel-rgb.txt. the patches will be send soon later.
Don't create yet another common panel file. We already have panel-dpi.txt which is for digital parallel interface.
Rob
| |