lkml.org 
[lkml]   [2017]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5] trace-cmd: Add ULL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31
    On Sat, 12 Aug 2017 11:30:45 -0600
    Michael Sartain <mikesart@fastmail.com> wrote:


    > Signed-off-by: Michael Sartain <mikesart@fastmail.com>
    > ---
    > kbuffer-parse.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kbuffer-parse.c b/kbuffer-parse.c
    > index 4e6e95e..dde642c 100644
    > --- a/kbuffer-parse.c
    > +++ b/kbuffer-parse.c
    > @@ -24,8 +24,8 @@
    >
    > #include "kbuffer.h"
    >
    > -#define MISSING_EVENTS (1 << 31)

    Actually, why not? This could also be just UL, because it's fine to
    shift 31, that would give us: 0x80000000 And that bit is all we care
    for.

    -- Steve

    > -#define MISSING_STORED (1 << 30)
    > +#define MISSING_EVENTS (1ULL << 31)
    > +#define MISSING_STORED (1ULL << 30)
    >
    > #define COMMIT_MASK ((1 << 27) - 1)
    >

    \
     
     \ /
      Last update: 2017-10-10 00:28    [W:3.594 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site