lkml.org 
[lkml]   [2017]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ath9k: debug: Simplify error checking
    Date
    Variable val is unsigned so checking whether it is less than zero is
    redundant.

    Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
    ---
    drivers/net/wireless/ath/ath9k/debug.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
    index 01fa301..3b93c23 100644
    --- a/drivers/net/wireless/ath/ath9k/debug.c
    +++ b/drivers/net/wireless/ath/ath9k/debug.c
    @@ -1164,10 +1164,7 @@ static ssize_t write_file_tpc(struct file *file, const char __user *user_buf,
    return -EFAULT;

    buf[len] = '\0';
    - if (kstrtoul(buf, 0, &val))
    - return -EINVAL;
    -
    - if (val < 0 || val > 1)
    + if (kstrtoul(buf, 0, &val) || val > 1)
    return -EINVAL;

    tpc_enabled = !!val;
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-10-08 23:29    [W:4.726 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site