lkml.org 
[lkml]   [2017]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RESEND PATCH] gpio: omap: Fix lost edge interrupts
On Tue, Oct 3, 2017 at 6:17 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:

> Now acking of edge irqs happens the following way:
> - omap_gpio_irq_handler
> - "isr" = read irq status
> - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask);
> ^ clear edge status, so irq can be accepted
> - loop while "isr"
> generic_handle_irq()
> - handle_edge_irq()
> - desc->irq_data.chip->irq_ack(&desc->irq_data);
> - omap_gpio_ack_irq()
> it might be that at this moment edge IRQ was triggered again and it will be
> cleared and IRQ will be lost.
>
> Use handle_simple_irq and clear edge interrupts early without disabling them in
> omap_gpio_irq_handler to avoid loosing interrupts.
>
> [1] https://marc.info/?l=linux-omap&m=149004465313534&w=2
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>

Patch applied for fixes.

I guess it is the right thing to do?

Other maintainers need to tell me if I should hold it back.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-10-07 13:18    [W:0.061 / U:8.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site