Messages in this thread | | | Date | Sat, 07 Oct 2017 03:01:03 +0100 (WEST) | Subject | Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef | From | David Miller <> |
| |
From: Michael Chan <michael.chan@broadcom.com> Date: Fri, 6 Oct 2017 18:27:31 -0700
> On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins <jtoppins@redhat.com> wrote: >> There is no reason to wrap the data structures inside the ifdef. > > What's so bad about wrapping unused data structures inside #ifdef? > These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is > defined.
Yeah I agree, this ifdef is actually a good way to trap unintentional usage of those datastructures so it's doubly best to keep the ifdef.
| |