lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1][cover-letter] mm/mempolicy.c: Fix get_nodes() off-by-one error.
Date
Luis Felipe Sandoval Castro <luis.felipe.sandoval.castro@intel.com>
writes:

> According to mbind() and set_mempolicy()'s man pages the argument "maxnode"
> specifies the max number of bits in the "nodemask" (which is also to be passed
> to these functions) that should be considered for the memory policy. If maxnode
> = 2, only two bits are to be considered thus valid node masks are: 0b00, 0b01,
> 0b10 and 0b11.

We can't change this unfortunately, it would break old binaries (like
libnuma) which assume the old interface.

The only way to fix it would be to add a new system call and keep
the old one for compatibility, but that would seem like overkill just
for this.

You always have to add +1, sorry.

Perhaps it could be better documented.

-Andi

\
 
 \ /
  Last update: 2017-10-07 00:13    [W:0.313 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site