lkml.org 
[lkml]   [2017]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4.4 22/50] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show()
    From
    Date
    On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
    > 4.4-stable review patch. If anyone has any objections, please let me know.

    I hope this patch is just to make porting some other patch easier.

    Otherwise, this has no place in stable as it has no change in
    functionality and is a completely trivial savings in cpu only.


    > ------------------
    >
    > From: Markus Elfring <elfring@users.sourceforge.net>
    >
    >
    > [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ]
    >
    > Strings which did not contain data format specifications should be put
    > into a sequence. Thus use the corresponding function "seq_puts".
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/pinctrl/mvebu/pinctrl-mvebu.c | 9 +++++----
    > 1 file changed, 5 insertions(+), 4 deletions(-)
    >
    > --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
    > +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
    > @@ -195,11 +195,12 @@ static void mvebu_pinconf_group_dbg_show
    > seq_printf(s, "o");
    > seq_printf(s, ")");
    > }
    > - } else
    > - seq_printf(s, "current: UNKNOWN");
    > + } else {
    > + seq_puts(s, "current: UNKNOWN");
    > + }
    >
    > if (grp->num_settings > 1) {
    > - seq_printf(s, ", available = [");
    > + seq_puts(s, ", available = [");
    > for (n = 0; n < grp->num_settings; n++) {
    > if (curr == &grp->settings[n])
    > continue;
    > @@ -222,7 +223,7 @@ static void mvebu_pinconf_group_dbg_show
    > seq_printf(s, ")");
    > }
    > }
    > - seq_printf(s, " ]");
    > + seq_puts(s, " ]");
    > }
    > return;
    > }
    >
    >

    \
     
     \ /
      Last update: 2017-10-06 11:10    [W:4.195 / U:1.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site