lkml.org 
[lkml]   [2017]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver
    Date
    > -----Original Message-----
    > From: Darren Hart [mailto:dvhart@infradead.org]
    > Sent: Thursday, October 5, 2017 12:22 PM
    > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
    > Cc: andy.shevchenko@gmail.com; linux-kernel@vger.kernel.org; platform-
    > driver-x86@vger.kernel.org; luto@kernel.org; quasisec@google.com;
    > pali.rohar@gmail.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de;
    > greg@kroah.com
    > Subject: Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI
    > descriptor into it's own driver
    >
    > On Thu, Oct 05, 2017 at 02:47:15PM +0000, Mario.Limonciello@dell.com wrote:
    > > > >
    > > > > So I believe it should be a mandatory runtime dependency due to needing
    > > > > the symbol dell_wmi_get_interface_version. Depmod should be handling
    > > > > this then no?
    > > >
    > > > This was nagging me all night, and I was thinking the last time I had to
    > > > use this it was indeed a runtime dependency. Sorry for the noise on
    > > > this.
    > > >
    > > > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
    > > > module if the dependent drivers are modules.
    > > >
    > > > --
    > > > Darren Hart
    > > > VMware Open Source Technology Center
    > >
    > > Even if the others are modules shouldn't module ordering from depmod still
    > DTRT?
    > > You still won't be able to load dell-wmi.ko until dell-wmi-descriptor.ko was
    > loaded.
    > >
    >
    > I worded that wrong *facepalm*, let me try again...
    >
    > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
    > module if the dependent drivers are built-in.
    >

    OK got it. I've got Kconfig adjusted for this. Unlike DELL_SMBIOS,
    DELL_WMI_DESCRIPTOR could still be used on it's own.

    \
     
     \ /
      Last update: 2017-10-05 19:32    [W:9.059 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site