| Subject | Re: [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and IDs | | From | Richard Leitner <> | | Date | Wed, 4 Oct 2017 09:39:12 +0200 |
| |
Hi Serge,
On 09/16/2017 12:42 PM, Serge Semin wrote: > There are USB2517 and USB2517i hubs, which have almost the same > registers space as already supported USB251xbi series. The difference > it in DIDs and in few functions. This patch adds the USB2517/i data > structures to the driver, so it would have different setting depending > on the device discovered on i2c-bus. > > Signed-off-by: Serge Semin <fancer.lancer@gmail.com> > --- > Documentation/devicetree/bindings/usb/usb251xb.txt | 3 ++- > drivers/usb/misc/usb251xb.c | 21 ++++++++++++++++++++- > 2 files changed, 22 insertions(+), 2 deletions(-)
...
Please also mention support for the USB2517(i) hubs in the Kconfig helptext of the driver @ drivers/usb/misc/Kconfig. Thanks.
Apart from that the patch looks good to me.
regards, Richard.L
|