Messages in this thread | | | Subject | Re: [PATCHv2 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing | From | Laura Abbott <> | Date | Wed, 4 Oct 2017 15:07:21 -0700 |
| |
On 10/04/2017 04:29 AM, Pintu Kumar wrote: > The whole thing about this test is to share an FD over 2 independent processes. > I think sharing an FD using fork() [parent/child] is not a real use > case scenarios. > Some people may not like the fork example. > Initially when I started with ION, I also needed an FD sharing mechanism between > 2 different process. Thus I came up with this framework using ipcsocket. > Later, if required, we can even replace this with binder_ipc for > android use cases. > Anyways, binder_ipc also internally uses the same concept as this ipcsocket. > To reduce the pain, we can invoke both the tests from a single shell scripts. > I will try to include the same in kselftests, if possible. > > If fork example is really required, we can add another test for it. > This is my opinion.
You don't have to treat them as parent/child. Once they've forked the processes are independent so you can use the same socket behavior you've implemented here. I prefer the fork behavior over the shell script because it means I only need to copy one file vs. three if I'm testing in other environments but I'm not that opposed.
Thanks, Laura
| |