Messages in this thread | | | Date | Wed, 04 Oct 2017 10:44:30 -0700 (PDT) | Subject | Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro | From | David Miller <> |
| |
From: Matthias Kaehlcke <mka@chromium.org> Date: Wed, 4 Oct 2017 10:42:15 -0700
> Given that this doesn't seem to be a widespread issue in the kernel > personally I would consider the conversion to a macro in this case an > acceptable solution, though it is definitely ugly. However I'm not the > owner of the driver or the subsystem, so my opinion doesn't really > carry much weight here ;-)
Losing type checking is a serious regression as far as I am concerned.
| |