Messages in this thread | | | Subject | Re: [PATCH] PM / OPP: Add missing of_node_put(np) | From | Stephen Boyd <> | Date | Wed, 4 Oct 2017 09:42:05 -0700 |
| |
On 10/03/2017 11:05 PM, Viresh Kumar wrote: > From: Tobias Jordan <Tobias.Jordan@elektrobit.com> > > The for_each_available_child_of_node() loop in _of_add_opp_table_v2() > doesn't drop the reference to "np" on errors. Fix that. > > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings") > Cc: 4.3+ <stable@vger.kernel.org> # 4.3+ > Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com> > [ VK: Improved commit log. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Looks like that opp_table->np = opp_np assignment in this function needs to do an of_node_get() because the caller of this function puts the pointer unconditionally.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |