Messages in this thread | | | Subject | Re: [PATCH 3/3] wireless: iwlwifi: wrap macro into braces | From | Joe Perches <> | Date | Wed, 04 Oct 2017 09:14:24 -0700 |
| |
On Wed, 2017-10-04 at 17:57 +0200, Christoph Böhmwalder wrote: > Macros should always be wrapped in braces, so fix this instance. > > Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at> > --- > drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c b/drivers/net/wireless/intel/iwlwifi/iwl-io.c > index efb1998dcabd..0211963b3e71 100644 > --- a/drivers/net/wireless/intel/iwlwifi/iwl-io.c > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-io.c > @@ -252,7 +252,7 @@ IWL_EXPORT_SYMBOL(iwl_force_nmi); > > static const char *get_rfh_string(int cmd) > { > -#define IWL_CMD(x) case x: return #x > +#define IWL_CMD(x) { case x: return #x; }
I think this unnecessary. Maybe: http://lists.infradead.org/pipermail/ath10k/2017-February/009335.html
> #define IWL_CMD_MQ(arg, reg, q) { if (arg == reg(q)) return #reg; }
But this should use do { ... } while (0)
| |