lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] virt: Add vboxguest driver for Virtual Box Guest integration
From
Date
Hi,

On 03-10-17 13:41, Hans de Goede wrote:

<snip>

>>> +#define CHECK_IOCTL_IN(req)                             \
>>> +do {                                         \
>>> +    if ((req)->Hdr.cbIn != (sizeof((req)->Hdr) + sizeof((req)->u.In)) || \
>>> +        (req)->Hdr.cbOut != sizeof((req)->Hdr))                 \
>>> +        return -EINVAL;                             \
>>> +} while (0)
>>
>> Make these things functions instead of macros.
>
> Turning these into functions is a good idea I will do so for v2.

Correction, I forgot that the passed in "req" macro
argument has a different type with all the calls, so
these cannot be changed into functions because they
rely on sizeof on the specific type to do the size
checks.

Regards,

Hans

\
 
 \ /
  Last update: 2017-10-04 11:33    [W:0.053 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site