lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Sony-laptop: Use common error handling code in sony_nc_setup_rfkill()
From
Date
>> I performed another simple software refactoring.
>
> Which is _useless_ per se

I disagree in this case because the goal of a refactoring should be
to adjust something in a desired direction without changing
the provided functionality.


> by the reasons you had been told already _several_ times about.

There can be other reasons why you do not like a concrete change.


> Either you do a real fix (propagate correct error codes
> to upper layers), or just don't bother at all.

Have the involved contributors any preferences on organisation
of corresponding update steps?

* Correct exception handling first and then apply the shown
source code reduction again.

* Combine better exception handling with smaller code
in one patch.

* Addition of the tag “Fixes” in the commit message?

Regards,
Markus

\
 
 \ /
  Last update: 2017-10-31 17:58    [W:0.964 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site