lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 17/20] regulator: fan53555: fix I2C device ids
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guillaume Tucker <guillaume.tucker@collabora.com>

    commit fc1111b885437f374ed54aadda44d8b241ebd2a3 upstream.

    The device tree nodes all correctly describe the regulators as
    syr827 or syr828, but the I2C device id is currently set to the
    wildcard value of syr82x in the driver. This causes udev to fail
    to match the driver module with the modalias data from sysfs.

    Fix this by replacing the I2C device ids with ones that match the
    device tree descriptions, with syr827 and syr828. Tested on
    Firefly rk3288 board. The syr82x id was not used anywhere.

    Fixes: e80c47bd738b (regulator: fan53555: Export I2C module alias information)
    Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/regulator/fan53555.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/regulator/fan53555.c
    +++ b/drivers/regulator/fan53555.c
    @@ -434,7 +434,10 @@ static const struct i2c_device_id fan535
    .name = "fan53555",
    .driver_data = FAN53555_VENDOR_FAIRCHILD
    }, {
    - .name = "syr82x",
    + .name = "syr827",
    + .driver_data = FAN53555_VENDOR_SILERGY
    + }, {
    + .name = "syr828",
    .driver_data = FAN53555_VENDOR_SILERGY
    },
    { },

    \
     
     \ /
      Last update: 2017-10-31 11:22    [W:4.053 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site