lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] f2fs: don't bother with inode->i_version
From
Date
On 2017/10/30 23:11, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
>
> f2fs does not set the SB_I_VERSION flag, so the i_version will never
> be incremented on write. It was recently changed to increment the
> i_version on a quota write, which isn't necessary here.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
> fs/f2fs/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 933c3d529e65..b3359158e7be 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -618,7 +618,6 @@ static struct inode *f2fs_alloc_inode(struct super_block *sb)
> init_once((void *) fi);
>
> /* Initialize f2fs-specific inode info */
> - fi->vfs_inode.i_version = 1;
> atomic_set(&fi->dirty_pages, 0);
> fi->i_current_depth = 1;
> fi->i_advise = 0;
> @@ -1386,7 +1385,6 @@ static ssize_t f2fs_quota_write(struct super_block *sb, int type,
>
> if (len == towrite)
> return 0;
> - inode->i_version++;
> inode->i_mtime = inode->i_ctime = current_time(inode);
> f2fs_mark_inode_dirty_sync(inode, false);
> return len - towrite;
>

\
 
 \ /
  Last update: 2017-11-01 03:15    [W:0.050 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site