Messages in this thread | | | From | Kees Cook <> | Date | Mon, 30 Oct 2017 14:20:06 -0700 | Subject | Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call() |
| |
On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook <keescook@chromium.org> wrote: > (re-sending to Jessica's @korg address...) > > The module_param_call() macro was explicitly casting the .set and .get > function prototypes away with (void *). This can lead to hard-to-find > type mismatches. Additionally, it creates problems for static checkers > and Control Flow Itegrity compiler features, which depend on clustering > function call sites based on prototype signature. > > This removes the casts and fixes all the incorrect prototypes tree-wide.
A quick ping on this. I'd really like to land this in 4.15, as it's relatively trivial. How does this look to you Jessica?
-Kees
-- Kees Cook Pixel Security
| |