Messages in this thread | | | Date | Sun, 29 Oct 2017 18:54:09 +0300 | From | Yury Norov <> | Subject | Re: [PATCH] Fix line too long warning |
| |
Hi Kien,
On Sat, Oct 28, 2017 at 10:46:13PM -0400, Kien Ha wrote: > >From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 > From: Kien Ha <kienha9922@gmail.com> > Date: Fri, 27 Oct 2017 14:07:55 -0400 > Subject: [PATCH] Fix line too long warning > > Signed-off-by: Kien Ha <kienha9922@gmail.com> > --- > drivers/staging/rtlwifi/base.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c > index b88b0e8edd3d..bbc80f976e12 100644 > --- a/drivers/staging/rtlwifi/base.c > +++ b/drivers/staging/rtlwifi/base.c > @@ -1283,7 +1283,8 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw, > } else { > if (rtlmac->mode == WIRELESS_MODE_B) { > tcb_desc->hw_rate = > - rtlpriv->cfg->maps[RTL_RC_CCK_RATE11M]; > + rtlpriv->cfg->maps[ > + RTL_RC_CCK_RATE11M];
At first, if you fix this, you should also fix similar problem 3 lines below, right?
> } else { > tcb_desc->hw_rate = > rtlpriv->cfg->maps[RTL_RC_OFDM_RATE54M];
At second, and most important, refer Documentation/process/coding-style.rst: Now, some people will claim that having 8-character indentations makes the code move too far to the right, and makes it hard to read on a 80-character terminal screen. The answer to that is that if you need more than 3 levels of indentation, you're screwed anyway, and should fix your program.
The real problem here is not "line too long", but "indentation level too big" - 5. And it worth to address real problem.
Yury
| |