Messages in this thread | | | Subject | Re: [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask() | From | Florian Fainelli <> | Date | Sat, 28 Oct 2017 09:54:07 -0700 |
| |
On 10/24/2017 12:54 PM, Doug Berger wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > The pin2mask() accessor only shuffles BIT ORDER in big endian systems, > i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or > bit 15 or bit 31 or so. > > The brcmstb only uses big endian BYTE ORDER which will be taken car of > by the ->write_reg() callback. > > Just use BIT(offset) to assign the bit. > > Cc: Gregory Fong <gregory.0xf0@gmail.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |