Messages in this thread | | | From | Kees Cook <> | Date | Fri, 27 Oct 2017 06:58:00 +0200 | Subject | Re: [PATCH] net: tipc: Convert timers to use timer_setup() |
| |
On Tue, Oct 24, 2017 at 11:44 AM, Jon Maloy <jon.maloy@ericsson.com> wrote: > NAK. It doesn't sound like a good idea to send this to net. Especially since one of these timers has already been refactored in net-next.
Hi! I'm not sure what you mean about the one timer issue. I don't see any use of timer_setup() in net/tipc (and no recent conversions to the older setup_timer() API). What's the preferred path for landing this API conversion in net/tipc/?
And, just to note, these changes are almost entirely mechanical. The only "special" case is in tipc_sk_timeout() where the argument needs to be slightly adjusted to fetch the tsk from the sk again.
Thanks!
-Kees
-- Kees Cook Pixel Security
| |