Messages in this thread | | | Subject | Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module | From | Ghazale Hosseinabadi <> | Date | Fri, 27 Oct 2017 17:36:09 -0700 |
| |
On 10/27/2017 04:19 PM, Hal Rosenstock wrote: > On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: >> >> On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>>> When running ibstat (if transceiver is not connected in adapter): >>>> >>>> ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid >>>> argument >>> Any output before that ? >> no, It only prints this line. > and setting the width to 1x in the driver so the rate file is properly > populated fixes this ? Yes, because a value is written in /sys/class/infiniband/mlx5_X/ports/1/rate > I must be missing something as to what is going > on in this scenario. Without this bug fix, file /sys/class/infiniband/mlx5_X/ports/1/rate is empty, which results in ibpanic.
-- Ghazale > > sysfs.c:rate_show is inconsistent as it paves over an invalid speed > setting that to SDR but does not pave over invalid width returning > -EINVAL but this comment is in another "direction". > > -- Hal > >> -- Ghazale >>> I'm trying to understand how far it gets. It >>> looks to me that empty rate file would be parsed as 0 and ibstat would >>> show that rate. ibpanic would occur if file was not found but I could be >>> missing something. >>> >>
| |