Messages in this thread | | | From | Bogdan Purcareata <> | Subject | RE: [PATCH 3/5] staging: fsl-dpaa2/eth: Don't account SWA in tx_data_offset | Date | Fri, 27 Oct 2017 14:42:26 +0000 |
| |
> -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > Sent: Friday, October 27, 2017 5:34 PM > To: Bogdan Purcareata <bogdan.purcareata@nxp.com> > Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>; > gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > devel@driverdev.osuosl.org > Subject: Re: [PATCH 3/5] staging: fsl-dpaa2/eth: Don't account SWA in > tx_data_offset > > On Fri, Oct 27, 2017 at 02:31:22PM +0000, Bogdan Purcareata wrote: > > > -----Original Message----- > > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > > > Sent: Friday, October 27, 2017 5:27 PM > > > To: Bogdan Purcareata <bogdan.purcareata@nxp.com> > > > Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@nxp.com>; > > > gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > > > devel@driverdev.osuosl.org > > > Subject: Re: [PATCH 3/5] staging: fsl-dpaa2/eth: Don't account SWA in > > > tx_data_offset > > > > > > > > > On Fri, Oct 27, 2017 at 02:11:34PM +0000, Bogdan Purcareata wrote: > > > > When configuring the Tx buffer layout, the software annotation size is > > > > mentioned, and MC accounts for it when configuring the frame > > > > tx_data_offset. No need to handle it in the driver as well. > > > > > > > > > > The impact is that we allocate slightly less memory right? > > > > Yes, 64B per frame. > > Ok. Cool. Please put this kind of stuff in the changelog. At first I > thought it was maybe a buffer overflow just from reading what was in the > email without looking at the code.
Okay, will update in v2.
Thank you! Bogdan P.
| |