Messages in this thread | | | From | Kees Cook <> | Date | Tue, 24 Oct 2017 13:07:34 -0700 | Subject | Re: [PATCH] sound: oss: waveartist: Convert timers to use timer_setup() |
| |
On Tue, Oct 24, 2017 at 12:25 PM, Takashi Iwai <tiwai@suse.de> wrote: > On Tue, 24 Oct 2017 17:35:21 +0200, > Kees Cook wrote: >> >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer explicitly. >> >> Cc: Jaroslav Kysela <perex@perex.cz> >> Cc: Takashi Iwai <tiwai@suse.com> >> Cc: David Howells <dhowells@redhat.com> >> Cc: alsa-devel@alsa-project.org >> Signed-off-by: Kees Cook <keescook@chromium.org> > > I'll skip this as sound/oss/* is already disabled in recent kernels in > kbuild, and we're going to remove the whole code soon later.
At the end of these conversions, the old init_timer() and setup_timer() APIs will be removed, which would break anything still trying to use it (obviously). But if sound/oss/* is _already_ unbuildable, then sure, this is fine by me to leave out. :)
Thanks!
-Kees
-- Kees Cook Pixel Security
| |