lkml.org 
[lkml]   [2017]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 11/13] xen/pvcalls: implement poll command
From
Date
On 10/23/2017 07:06 PM, Stefano Stabellini wrote:
> On Tue, 17 Oct 2017, Boris Ostrovsky wrote:
>>> +static unsigned int pvcalls_front_poll_passive(struct file *file,
>>> + struct pvcalls_bedata *bedata,
>>> + struct sock_mapping *map,
>>> + poll_table *wait)
>>> +{
>>> + int notify, req_id, ret;
>>> + struct xen_pvcalls_request *req;
>>> +
>>> + if (test_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT,
>>> + (void *)&map->passive.flags)) {
>>> + uint32_t req_id = READ_ONCE(map->passive.inflight_req_id);
>>> +
>>> + if (req_id != PVCALLS_INVALID_ID &&
>>> + READ_ONCE(bedata->rsp[req_id].req_id) == req_id)
>>> + return POLLIN | POLLRDNORM;
>>
>> Same READ_ONCE() question as for an earlier patch.
> Same answer :-)


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

>
>
>>> +
>>> + poll_wait(file, &map->passive.inflight_accept_req, wait);
>>> + return 0;
>>> + }
>>> +

\
 
 \ /
  Last update: 2017-10-24 16:02    [W:0.069 / U:3.776 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site