lkml.org 
[lkml]   [2017]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] drivers: phy: broadcom: Add driver for Cygnus USB phy controller
On 2017-10-24 06:37, Raveendra Padasalagi wrote:
> Add driver for Broadcom's USB phy controller's used in Cygnus
> familyof SoC. Cygnus has three USB phy controller's, port 0,
> port 1 provides USB host functionality and port 2 can be configured
> for host/device role.
>
> Configuration of host/device role for port 2 is achieved based on
> the extcon events, the driver registers to extcon framework to get
> appropriate connect events for Host/Device cables connect/disconnect
> states based on VBUS and ID interrupts.

Minor issues commented inline.


> +#define USB2_IDM_IDM_IO_CONTROL_DIRECT_OFFSET 0x0408
> +#define USB2_IDM_IDM_IO_CONTROL_DIRECT_CLK_ENABLE BIT(0)

Here you define reg bits using BIT(n).


> +#define SUSPEND_OVERRIDE_0 13
> +#define SUSPEND_OVERRIDE_1 14
> +#define SUSPEND_OVERRIDE_2 15
> +#define USB2_IDM_IDM_RESET_CONTROL_OFFSET 0x0800
> +#define USB2_IDM_IDM_RESET_CONTROL__RESET 0

And here without BIT(n). Either is fine but it may be better to be
consistent about it.


> +static int cygnus_phy_probe(struct platform_device *pdev)
> +{
> + struct resource *res;
> + struct cygnus_phy_driver *phy_driver;
> + struct phy_provider *phy_provider;
> + int i, ret;
> + u32 reg_val;
> + struct device *dev = &pdev->dev;
> + struct device_node *node = dev->of_node;
> +
> + /* allocate memory for each phy instance */
> + phy_driver = devm_kzalloc(dev, sizeof(struct cygnus_phy_driver),
> + GFP_KERNEL);
> + if (!phy_driver)
> + return -ENOMEM;
> +
> + phy_driver->num_phys = of_get_child_count(node);
> +
> + if (phy_driver->num_phys == 0) {
> + dev_err(dev, "PHY no child node\n");
> + return -ENODEV;
> + }
> +
> + phy_driver->instances = devm_kcalloc(dev, phy_driver->num_phys,
> + sizeof(struct cygnus_phy_instance),
> + GFP_KERNEL);

I don't think kcalloc is safe here. E.g. In cygnus_phy_shutdown you
iterate over all instances reading the .power value. If
cygnus_phy_shutdown gets called before having each instance powered up,
you'll read random memory as .power value.

\
 
 \ /
  Last update: 2017-10-24 08:26    [W:0.121 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site