lkml.org 
[lkml]   [2017]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Clockevents: Always call clockevents_program_event
On Tue, 24 Oct 2017, Prasad Sodagudi wrote:

> Currently tick_program_event function is not calling
> clockevents_program_event when 'expires == KTIME_MAX',
> it is just updating clockevent state to CLOCK_EVT_STATE_ONESHOT_STOPPED.
> clockevents_program_event function updates clockevent
> device next_event by checking clockevent device state,
> so always call clockevents_program_event() from tick_program_event.

No. This is fundmentally wrong. If the clockevent is in oneshot stopped
mode then you cannot call clockevents_program_event(). There is even a
warning in that code which will trigger.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-10-24 10:38    [W:0.194 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site