lkml.org 
[lkml]   [2017]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command
    On Mon, Oct 23, 2017 at 08:32:57AM -0500, Brijesh Singh wrote:
    > If both the command fails then we return status from the last command.
    > IIRC, in my previous patches I was returning status from sev_do_cmd()
    > instead of sev_platform_shutdown() but based on our previous
    > communication I thought you asked to return the status from the last
    > failed command. Did I miss understood ?

    So my problem is that it looks strange that you save an error value from
    sev_do_cmd() but you don't look at it. And as I said in the other mail,
    you should either ignore it and say so in a comment why it is OK to
    ignore it or handle it but not overwrite it without looking at it.

    Does that make more sense?

    --
    Regards/Gruss,
    Boris.

    ECO tip #101: Trim your mails when you reply.
    --

    \
     
     \ /
      Last update: 2017-10-23 16:11    [W:2.143 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site