lkml.org 
[lkml]   [2017]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] futex: do not fail on invalid op
On Mon, Oct 23, 2017 at 5:31 AM, Jiri Slaby <jslaby@suse.cz> wrote:
>
> So let us soften the failure to print only a (ratelimited) message and
> return 0 silently in these cases until userspace keeps up.

No, please make it do that ratelimited warning, but then continue as
if things were ok - trying to approximate what the code used to do.

Don't make it return success without actually doing anything.

So just make it do

oparg = 1 << (oparg & 31);

or something. That's what that sequence would have done at least on 32-bit x86.

Maybe that was what it happened to expect by random luck. And maybe it
didn't matter. But don't just say "it worked" without doing anything.

Linus

\
 
 \ /
  Last update: 2017-10-23 12:49    [W:0.037 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site