lkml.org 
[lkml]   [2017]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support
    On Thu, Oct 19, 2017 at 09:33:48PM -0500, Brijesh Singh wrote:
    > +static int __sev_platform_init(struct sev_data_init *data, int *error)
    > +{
    > + int rc = 0;
    > +
    > + mutex_lock(&fw_init_mutex);
    > +
    > + if (!fw_init_count) {

    I still don't like global semaphores. Can you get the status and check
    for PSTATE.INIT state and do the init only if the platform is in
    PSTATE.UNINIT?

    --
    Regards/Gruss,
    Boris.

    ECO tip #101: Trim your mails when you reply.
    --

    \
     
     \ /
      Last update: 2017-10-23 11:21    [W:4.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site