lkml.org 
[lkml]   [2017]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: xhci: tegra: use time64_t for printing timestamp
From
Date
On 20.10.2017 10:19, Arnd Bergmann wrote:
> The time_t type and time_to_tm() function are deprecated because
> of y2038 problems. In this driver, they are used to pretty-print
> the timestamp of the firmware build. This is fine as long as
> we don't get a firmware build past 2038.
>
> Converting to time64_t and time64_to_tm() avoids the deprecated
> interfaces and works until 2106, when the firmware-defined
> data structure overflows.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/host/xhci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index 74436f8ca538..39b6e93130d3 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -771,7 +771,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
> struct device *dev = tegra->dev;
> const struct firmware *fw;
> unsigned long timeout;
> - time_t timestamp;
> + time64_t timestamp;
> struct tm time;
> u64 address;
> u32 value;
> @@ -877,7 +877,7 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
> }
>
> timestamp = le32_to_cpu(header->fwimg_created_time);
> - time_to_tm(timestamp, 0, &time);
> + time64_to_tm(timestamp, 0, &time);
>
> dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
>

Thanks, adding to queue

-Mathias

\
 
 \ /
  Last update: 2017-10-22 17:37    [W:0.065 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site