lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata() parameter
Date
The use case is when called by struct hmm_devmem_ops.fault() which passes a const struct page * pointer and hmm_devmem_page_get_drvdata() is called to get the private data.
Since HMM was only recently added, it only affects kernels after September 8, 2017.

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Monday, October 2, 2017 2:41 PM
> To: Jérôme Glisse <jglisse@redhat.com>
> Cc: linux-kernel@vger.kernel.org; linux-mm@kvack.org; Ralph Campbell
> <rcampbell@nvidia.com>
> Subject: Re: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata()
> parameter
>
> On Mon, 2 Oct 2017 15:32:54 -0400 Jérôme Glisse <jglisse@redhat.com>
> wrote:
>
> > From: Ralph Campbell <rcampbell@nvidia.com>
> >
> > Constify pointer parameter to avoid issue when use from code that only
> > has const struct page pointer to use in the first place.
>
> That's rather vague. Does such calling code exist in the kernel? This affects the
> which-kernel-gets-patched decision.

\
 
 \ /
  Last update: 2017-10-02 23:57    [W:0.068 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site