lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/2] ARM: s3c64xx: Delete two error messages for a failed memory allocation in samsung_bl_set()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 2 Oct 2017 22:20:39 +0200

    Omit extra messages for a memory allocation failure in this function.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/arm/mach-s3c64xx/dev-backlight.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/arch/arm/mach-s3c64xx/dev-backlight.c b/arch/arm/mach-s3c64xx/dev-backlight.c
    index e62e789f9aee..7e2db762c442 100644
    --- a/arch/arm/mach-s3c64xx/dev-backlight.c
    +++ b/arch/arm/mach-s3c64xx/dev-backlight.c
    @@ -94,17 +94,14 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,

    samsung_bl_device = kmemdup(&samsung_dfl_bl_device,
    sizeof(struct platform_device), GFP_KERNEL);
    - if (!samsung_bl_device) {
    - printk(KERN_ERR "%s: no memory for platform dev\n", __func__);
    + if (!samsung_bl_device)
    return;
    - }

    samsung_bl_drvdata = kmemdup(&samsung_dfl_bl_data,
    sizeof(samsung_dfl_bl_data), GFP_KERNEL);
    - if (!samsung_bl_drvdata) {
    - printk(KERN_ERR "%s: no memory for platform dev\n", __func__);
    + if (!samsung_bl_drvdata)
    goto err_data;
    - }
    +
    samsung_bl_device->dev.platform_data = &samsung_bl_drvdata->plat_data;
    samsung_bl_drvdata->gpio_info = gpio_info;
    samsung_bl_data = &samsung_bl_drvdata->plat_data;
    --
    2.14.2
    \
     
     \ /
      Last update: 2017-10-02 22:41    [W:3.038 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site