Messages in this thread | | | Date | Thu, 19 Oct 2017 16:15:05 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 net-next 1/2] net: dsa: lan9303: Add port_fast_age and port_fdb_dump methods |
| |
> > +/* Clear learned (non-static) entry on given port */ > > +static void alr_loop_cb_del_port_learned(struct lan9303 *chip, u32 dat0, > > + u32 dat1, int portmap, void *ctx) > > +{ > > + int *port = ctx; > > You can get the value directly to make the line below more readable: > > int port = *(int *)ctx;
You have to be a bit careful with this. You often see people submitting patches taking away casts for void * pointers. If they do that here, it should at least not compile...
So maybe do it in two steps?
int * pport = ctx; int port = *pport;
??? Andrew
| |