Messages in this thread | | | Subject | Re: [PATCH 3/5] powerpc-pseries: Delete an unnecessary variable initialisation in iommu_pseries_alloc_group() | From | SF Markus Elfring <> | Date | Thu, 19 Oct 2017 13:49:17 +0200 |
| |
>> static struct iommu_table_group *iommu_pseries_alloc_group(int node) >> { >> - struct iommu_table_group *table_group = NULL; >> + struct iommu_table_group *table_group; >> struct iommu_table *tbl = NULL; >> struct iommu_table_group_link *tgl = NULL; >> > > I think initializing pointers to NULL is generally a good idea.
This one would also not be needed if the call of the function “kzalloc_node” could be specified in the same statement.
> Removing these initializers adds no value, to the contrary.
This small update step is just a “preparation” for the subsequent two suggestions in this patch series.
Regards, Markus
| |