lkml.org 
[lkml]   [2017]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory
From
Date


On 10/17/17 3:39 PM, David Rientjes wrote:
> On Wed, 18 Oct 2017, Yang Shi wrote:
>
>>> Yes, this should catch occurrences of "huge unreclaimable slabs", right?
>>
>> Yes, it sounds so. Although single "huge" unreclaimable slab might not result
>> in excessive slabs use in a whole, but this would help to filter out "small"
>> unreclaimable slab.
>>
>
> Keep in mind this is regardless of SLAB_RECLAIM_ACCOUNT: your patch has
> value beyond only unreclaimable slab, it can also be used to show
> instances where the oom killer was invoked without properly reclaiming
> slab. If the total footprint of a slab cache exceeds 5%, I think a line
> should be emitted unconditionally to the kernel log.

OK, sounds good. I will propose an incremental patch to see the comments.

Thanks,
Yang

>

\
 
 \ /
  Last update: 2017-10-22 17:17    [W:0.179 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site