lkml.org 
[lkml]   [2017]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] liquidio: mark expected switch fall-through in octeon_destroy_resources
On Tue, Oct 17, 2017 at 02:01:45PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> This code was tested by compilation only (GCC 7.2.0 was used).
> Please, verify if the actual intention of the code is to fall through.
>
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> index e4a112c..4c3b568 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
> @@ -747,7 +747,7 @@ static void octeon_destroy_resources(struct octeon_device *oct)
>
> if (lio_wait_for_oq_pkts(oct))
> dev_err(&oct->pci_dev->dev, "OQ had pending packets\n");
> -
> + /* fall through */
> case OCT_DEV_INTR_SET_DONE:
> /* Disable interrupts */
> oct->fn_list.disable_interrupt(oct, OCTEON_ALL_INTR);
> --
> 2.7.4
>

Acked-by: Felix Manlunas <felix.manlunas@cavium.com>

\
 
 \ /
  Last update: 2017-10-22 17:16    [W:0.057 / U:2.368 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site