Messages in this thread Patch in this message | | | Date | Wed, 18 Oct 2017 09:23:03 -0700 | From | tip-bot for Kamalesh Babulal <> | Subject | [tip:core/objtool] objtool: Print top level commands on incorrect usage |
| |
Commit-ID: 6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e Gitweb: https://git.kernel.org/tip/6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e Author: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> AuthorDate: Sat, 14 Oct 2017 20:17:54 +0530 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 18 Oct 2017 15:22:26 +0200
objtool: Print top level commands on incorrect usage
Print top-level objtool commands, along with the error on incorrect command line usage. Objtool command line parser exit's with code 129, for incorrect usage. Convert the cmd_usage() exit code also, to maintain consistency across objtool.
After the patch:
$ ./objtool -j
Unknown option: -j
usage: objtool COMMAND [ARGS]
Commands: check Perform stack metadata validation on an object file orc Generate in-place ORC unwind tables for an object file
$ echo $? 129
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- tools/objtool/objtool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c index 31e0f91..07f3299 100644 --- a/tools/objtool/objtool.c +++ b/tools/objtool/objtool.c @@ -70,7 +70,7 @@ static void cmd_usage(void) printf("\n"); - exit(1); + exit(129); } static void handle_options(int *argc, const char ***argv) @@ -86,9 +86,7 @@ static void handle_options(int *argc, const char ***argv) break; } else { fprintf(stderr, "Unknown option: %s\n", cmd); - fprintf(stderr, "\n Usage: %s\n", - objtool_usage_string); - exit(1); + cmd_usage(); } (*argv)++;
| |