lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/2] x86: Add support for ZSTD-compressed kernel
Date
Nick Terrell <terrelln@fb.com> writes:

> @@ -133,6 +133,8 @@ $(obj)/vmlinux.bin.lzo: $(vmlinux.bin.all-y) FORCE
> $(call if_changed,lzo)
> $(obj)/vmlinux.bin.lz4: $(vmlinux.bin.all-y) FORCE
> $(call if_changed,lz4)
> +$(obj)/vmlinux.bin.zst: $(vmlinux.bin.all-y) FORCE
> + $(call if_changed,zstd)

In my experience the biggest problem with these options is that the
special command line tools needed for the build are often not installed
on the build systems.

So we turn it off and go back to GZIP to make the kernel build again.
Or we settle on some other option, but then when a better compressor
like ZSTD comes up it's too much trouble to change all the .configs.

There were recently some patches to add a stackprotector automatic
selection that probes if gcc supports stack overflow support,
and if not falls back automatically.

A similar thing for good compression options would seem better:
have a AUTO config option that uses ZSTD and fall back to GZIP
if it's not available. Then put it into defconfig.

I suspect that would increase your user base quite a bit.

-Andi

\
 
 \ /
  Last update: 2017-10-17 21:46    [W:0.048 / U:10.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site