lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [f2fs-dev] [PATCH] f2fs: avoid stale fi->gdirty_list pointer
On 10/17, Chao Yu wrote:
> On 2017/10/17 7:06, Jaegeuk Kim wrote:
> > On 10/16, Chao Yu wrote:
> >> On 2017/10/13 10:14, Jaegeuk Kim wrote:
> >>> When doing fault injection test, f2fs_evict_inode() didn't remove gdirty_list
> >>> which incurs a kernel panic due to wrong pointer access.
> >>>
> >>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> >>
> >> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> >>
> >> Minor thing, how about reverting judgment condition for readability?
> >>
> >> if (is_set_ckpt_flags(sbi, CP_ERROR_FLAG))
> >> f2fs_inode_synced()
> >
> > We don't need to expect such the errored corner case first. ;)
>
> Alright, making compiler being aware of this by using {un,}likely? :)

Yup, added. ;)

>
> Thanks,
>
> >
> >> else
> >> f2fs_bug_on()
> >>
> >> Thanks,
> >>
> >>> ---
> >>> fs/f2fs/inode.c | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> >>> index f6db9d533ca4..1ae5396c97d6 100644
> >>> --- a/fs/f2fs/inode.c
> >>> +++ b/fs/f2fs/inode.c
> >>> @@ -535,6 +535,8 @@ void f2fs_evict_inode(struct inode *inode)
> >>>
> >>> if (!is_set_ckpt_flags(sbi, CP_ERROR_FLAG))
> >>> f2fs_bug_on(sbi, is_inode_flag_set(inode, FI_DIRTY_INODE));
> >>> + else
> >>> + f2fs_inode_synced(inode);
> >>>
> >>> /* ino == 0, if f2fs_new_inode() was failed t*/
> >>> if (inode->i_ino)
> >>>
> >
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >

\
 
 \ /
  Last update: 2017-10-17 20:17    [W:0.049 / U:41.304 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site