lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 6/8] arm_pmu: Use of_cpu_node_to_id helper
On Tue, Oct 10, 2017 at 11:33:01AM +0100, Suzuki K Poulose wrote:
> Use the new generic helper, of_cpu_node_to_id(), to map a
> a phandle to the logical CPU number while parsing the
> PMU irq affinity.
>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

> ---
> drivers/perf/arm_pmu_platform.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c
> index 4eafa7a42e52..a96884e37eaf 100644
> --- a/drivers/perf/arm_pmu_platform.c
> +++ b/drivers/perf/arm_pmu_platform.c
> @@ -81,19 +81,10 @@ static int pmu_parse_irq_affinity(struct device_node *node, int i)
> return -EINVAL;
> }
>
> - /* Now look up the logical CPU number */
> - for_each_possible_cpu(cpu) {
> - struct device_node *cpu_dn;
> -
> - cpu_dn = of_cpu_device_node_get(cpu);
> - of_node_put(cpu_dn);
> -
> - if (dn == cpu_dn)
> - break;
> - }
> -
> - if (cpu >= nr_cpu_ids) {
> + cpu = of_cpu_node_to_id(dn);
> + if (cpu < 0) {
> pr_warn("failed to find logical CPU for %s\n", dn->name);
> + cpu = nr_cpu_ids;
> }
>
> of_node_put(dn);
> --
> 2.13.6
>

\
 
 \ /
  Last update: 2017-10-17 17:27    [W:0.079 / U:6.460 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site