lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests: add missing test result status in memory-hotplug test
From
Date
On 10/17/2017 01:06 AM, lei.yang@windriver.com wrote:
> From: Lei Yang <Lei.Yang@windriver.com>
>
> it only prints FAIL status when test fails, but doesn't print PASS
> status when test pass,this patch is to add PASS status in the test log.
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/memory-hotplug/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index afb2624..61d9b04 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -3,10 +3,10 @@ all:
> include ../lib.mk
>
> TEST_PROGS := mem-on-off-test.sh
> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 || echo "selftests: memory-hotplug [FAIL]"
> +override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> override EMIT_TESTS := echo "$(RUN_TESTS)"
>
> run_full_test:
> - @/bin/bash ./mem-on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
> + @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
>
> clean:
>

Looks good to me. I will get this into 4.15-rc1

thanks,
-- Shuah

\
 
 \ /
  Last update: 2017-10-17 16:21    [W:0.027 / U:11.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site