[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] fs, elf: drop MAP_FIXED usage from elf_map
On Tue 17-10-17 21:22:46, Baoquan He wrote:
> And as I said before, then we will still have the
> ungraceful 'mapping total'|'unmapping the rest' method.

yes I haven't touched this part and I guess you are right it can be
removed now, but this was not my primary concern to adddress so there is
still some room for improvements on top. If you want to refactor that
part, then feel free to do so but I think that we should address the
MAP_FIXED part first.

> If from a new code reader's point of view, the newly added elf_vm_mmap()
> plus the existing elf_map() may confuse people more.

Heh, I strongly suspect that this indirection is the last thing that
would make the code hard to grasp. The whole load_elf_binary is a giant
and incomprehensible mess.

Michal Hocko

 \ /
  Last update: 2017-10-17 15:33    [W:0.055 / U:5.652 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site