[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 05/23] drm/sun4i: tcon: Don't rely on encoders to enable the TCON
On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard
<> wrote:
> So far, we've required all the TCON-connected encoders to call the TCON
> enable and disable functions.
> This was made this way because in the RGB/LVDS case, the TCON is the CRTC
> and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we
> have another encoder down the road that needs to be programmed.
> We also needed to know which channel the encoder is connected to, which is
> encoder-specific.
> The CRTC's enable and disable callbacks can work just fine for our use
> case, and we can get the channel to use just by looking at the type of
> encoder, since that is fixed. Implement those callbacks, which will
> remove some of the encoder boilerplate.
> Signed-off-by: Maxime Ripard <>

Reviewed-by: Chen-Yu Tsai <>

 \ /
  Last update: 2017-10-17 11:30    [W:0.138 / U:28.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site