Messages in this thread | | | Date | Tue, 17 Oct 2017 10:14:02 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v4] mm, sysctl: make NUMA stats configurable |
| |
On Tue 17-10-17 16:03:44, kemi wrote: > On 2017年10月17日 15:54, Michal Hocko wrote: [...] > > So basically any value will enable numa stats. This means that we would > > never be able to extend this interface to e.g. auto mode (say value 2). > > I guess you meant to check sysctl_vm_numa_stat == ENABLE_NUMA_STAT? > > > > I meant to make it more general other than ENABLE_NUMA_STAT(non 0 is enough), > but it will make it hard to scale, as you said. > So, it would be like this: > 0 -- disable > 1 -- enable > other value is invalid. > > May add option 2 later for auto if necessary:)
But if you allow to set 2 without EINVAL now then you cannot change it in future.
-- Michal Hocko SUSE Labs
| |