lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata
Date
On Tuesday, October 17, 2017 6:16 AM, Jeffy Chen wrote:
>
> From: Tomasz Figa <tfiga@chromium.org>
>
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
>
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++--------
> -----
> drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++-----
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47
+++++++++++-------
> --
> include/drm/bridge/analogix_dp.h | 19 ++++----
> 4 files changed, 73 insertions(+), 69 deletions(-)
>

\
 
 \ /
  Last update: 2017-10-22 17:06    [W:0.130 / U:8.596 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site